-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge case first tx auth transfer issue #90
Comments
Hi everyone. Let me know if I can provide more information on the bug. |
So this is how I discovered the bug 🐛 I used I instantiated the cpk with some modifications to the Rinkeby network: Notably I use the new gnosis mastercopy at Then I sent the first Afterwards, the owner of the Proxy is the CPK Factory. Therefore, I am not able to interact with that Proxy anymore So I checked what the cpk says about ownership vs. what the on-chain GnosisSafeProxy says about it And they don't match
Output:
So cpk say the owner is 0x7015763d0a8F04263633106DE7a8F33B2334E51e - this is as expected However, if I check the actual GnosisSafe with It says 0x336c19296d3989e9e0c2561ef21c964068657c38 is the owner And this is on-chain so it's the single source of truth: This is the GnosisSafe that was deployed: |
There's an issue with using the CPKFactory:
https://github.com/gnosis/contract-proxy-kit/blob/bd3e9160a3c4e7c14f34bb5674475eee8560a629/contracts/CPKFactory.sol#L44
Specifically, the line above could fail but the whole transaction could succeed. Should have
require
d the transaction to succeed.The text was updated successfully, but these errors were encountered: