-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swapOwner can fail in CPKFactory #132
Comments
Closing this as this is a duplicate of #90 Edit: though admittedly this issue was described much better than the original 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If the estimated gas for
createProxyAndExecTransaction
is too lowswapOwner
can fail silently duringexecTransaction
to Gnosis Safe v1.2.0 while not rolling back the whole transaction.Users can potentially lose funds if they transfer assets to the proxy and ownership of the proxy is not successfully assigned to the user.
Transfer of ownership is not verified after the
swapOwner
call. We should probably check the return value ofexecTransaction
to check if the transaction was successful.example transaction
Should be considered for #126
The text was updated successfully, but these errors were encountered: