Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureRequests for cpk methods #89

Open
6 of 8 tasks
gitpusha opened this issue Aug 3, 2020 · 1 comment
Open
6 of 8 tasks

FeatureRequests for cpk methods #89

gitpusha opened this issue Aug 3, 2020 · 1 comment
Assignees
Labels
ts This issues is related to ts lib changes

Comments

@gitpusha
Copy link

gitpusha commented Aug 3, 2020

Hi,

As discussed with @germartinez in Telegram I will collect some feature requests here:

It would be great to have the following simple methods exposed by the CPK instance:

  • check if connected Signer already has a Proxy deployed: cpk.isProxyDeployed()

  • enable/disable Module: cpk.enableModule(address) / cpk.disableModule(address)

  • isModuleEnabled: cpk.isModuleEnabled(address)

  • getModules: cpk.getModules()

  • transfer ETH out of the GnosisSafeProxy: cpk.transfer(destination, amountInWei)

  • send ETH along with execTransactions: cpk.execTransactions(txs, {value})

  • getNetwork()

  • getBalance()


Edited by @germartinez to show what was implemented so far.

@gitpusha gitpusha changed the title FeatureRequests FeatureRequests for cpk methods Aug 3, 2020
@cag cag added the ts This issues is related to ts lib changes label Aug 3, 2020
@germartinez
Copy link
Member

Note for myself:

Consider the addition of a method that returns the current network, whether the app is running as a standalone app or as a Safe app.

  • Standalone: the network is obtained from await ethLibAdapter.getNetworkId()

  • Safe App: the network is obtained from the Safe Apps SDK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ts This issues is related to ts lib changes
Projects
None yet
Development

No branches or pull requests

3 participants