added integration tests #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anurag-rajawat your reviews |
anurag-rajawat
requested changes
Feb 20, 2024
|
We also need to add test cases to check the status of CRs. For more info, please check the expected outcomes in issue description. |
VedRatan
force-pushed
the
test
branch
8 times, most recently
from
747e19c
to
044b922
Compare
shivaccuknox
approved these changes
Feb 21, 2024
Signed-off-by: Ved Ratan <[email protected]> fixes Signed-off-by: Ved Ratan <[email protected]> fix helm path Signed-off-by: Ved Ratan <[email protected]> revert run steps Signed-off-by: Ved Ratan <[email protected]> removed ownerrefs Signed-off-by: Ved Ratan <[email protected]> run background Signed-off-by: Ved Ratan <[email protected]> run background Signed-off-by: Ved Ratan <[email protected]> added time Signed-off-by: Ved Ratan <[email protected]> added further tests Signed-off-by: Ved Ratan <[email protected]>
Signed-off-by: Anurag Rajawat <[email protected]>
Signed-off-by: Anurag Rajawat <[email protected]>
Signed-off-by: Anurag Rajawat <[email protected]>
anurag-rajawat
approved these changes
Feb 21, 2024
shivaccuknox
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR added the required integration tests for NImbus to make code complaint with the tests,Fixes #16
Does this PR introduce a breaking change?
Checklist
<type>: <description>conventionAdditional information for reviewer
Mention if this PR is part of any design or a continuation of previous PRs