-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Update controllers to update CRDs status #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anurag-rajawat
force-pushed
the
feat-crds-status
branch
3 times, most recently
from
February 11, 2024 11:11
47a4c5f
to
285b287
Compare
anurag-rajawat
force-pushed
the
feat-crds-status
branch
3 times, most recently
from
February 13, 2024 09:40
ed5bb39
to
b3192c3
Compare
anurag-rajawat
requested review from
seungsoo-lee,
daemon1024 and
shivaccuknox
February 13, 2024 09:44
seungsoo-lee
approved these changes
Feb 13, 2024
Signed-off-by: Anurag Rajawat <[email protected]>
anurag-rajawat
force-pushed
the
feat-crds-status
branch
from
February 14, 2024 09:25
b3192c3
to
aa038aa
Compare
Need to fix some other high-priority issues so marking it as a draft. |
Signed-off-by: Anurag Rajawat <[email protected]>
Signed-off-by: Anurag Rajawat <[email protected]>
Signed-off-by: Anurag Rajawat <[email protected]>
anurag-rajawat
force-pushed
the
feat-crds-status
branch
from
February 16, 2024 17:15
aa038aa
to
e47bef9
Compare
Signed-off-by: Anurag Rajawat <[email protected]>
shivaccuknox
approved these changes
Feb 19, 2024
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the following enhancements:
Fixes #51 and #61
Does this PR introduce a breaking change?
No
Checklist
<type>: <description>
conventionAdditional information for reviewer
ℹ️ In a subsequent PR, we'll update the docs, RBACs and adapters to update their policy status.
Sample Outputs:
Mention if this PR is part of any design or a continuation of previous PRs