Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add KubeArmor adapter #33

Closed
wants to merge 3 commits into from
Closed

feat: Add KubeArmor adapter #33

wants to merge 3 commits into from

Conversation

anurag-rajawat
Copy link
Collaborator

Description

This PR introduces an Adapter interface to allow flexible integration of security engines with nimbus. It also implements the first adapter for KubeArmor, allowing us to translate security policies into KubeArmor policies.

Does this PR introduce a breaking change?
No

Checklist

  • PR title follows the <type>: <description> convention
  • I use conventional commits in my commit messages
  • I have updated the documentation accordingly
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional information for reviewer

Mention if this PR is part of any design or a continuation of previous PRs

pkg/adapter/kubearmor/client.go Fixed Show fixed Hide fixed
pkg/adapter/kubearmor/client.go Fixed Show fixed Hide fixed
anurag-rajawat and others added 3 commits January 9, 2024 17:07
Signed-off-by: Anurag Rajawat <[email protected]>
… script will remove all resources at once)

fix:: Resolve an issue with deleting SIBs
- Fixed code so that when deleting a SIB, logs are properly generated and the created nimberpolicy is also deleted.

�style(cleanup): Add  license

Move script file

Deleted files
Signed-off-by: Anurag Rajawat <[email protected]>
@seungsoo-lee
Copy link
Collaborator

seungsoo-lee commented Jan 10, 2024

@anurag-rajawat

can you resolve this conflict? I think the conflict in the KubeArmor adapter codes between yours and mine. you can merge it.

@anurag-rajawat anurag-rajawat marked this pull request as draft January 10, 2024 03:23
@anurag-rajawat
Copy link
Collaborator Author

Superseded by #35 PR, where you can find more details and the implemented solution. Closing this one.

@anurag-rajawat anurag-rajawat deleted the feat-adapter branch January 14, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants