Fix Issue #28 #29
Closed
Fix Issue #28 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/cleanup/cleanup.sh
Outdated
There was a problem hiding this comment.
What is the specific purpose of this script in explicitly removing the CRs? Under what circumstances should a user execute it?
… script will remove all resources at once)
- Fixed code so that when deleting a SIB, logs are properly generated and the created nimberpolicy is also deleted.
|
Please squash commits. |
rajaSahil
approved these changes
Jan 7, 2024
There was a problem hiding this comment.
We don't need these sophisticated parameters in SecurityIntent; if there is a need for parameters, we'll specify those generically.
|
@seungsoo-lee, we can close this PR since the changes have been split into two separate PRs for better organization and review: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28
Does this PR introduce a breaking change?
Checklist
<type>: <description>conventionAdditional information for reviewer
Mention if this PR is part of any design or a continuation of previous PRs