Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(adapter): Add k8tls adapter #131

Merged
merged 4 commits into from
Jun 18, 2024
Merged

feat(adapter): Add k8tls adapter #131

merged 4 commits into from
Jun 18, 2024

Conversation

anurag-rajawat
Copy link
Collaborator

@anurag-rajawat anurag-rajawat commented May 26, 2024 •
edited
Loading

Description

Fixes #110

Does this PR introduce a breaking change?
No.

Checklist

  • PR title follows the <type>: <description> convention
  • I use conventional commits in my commit messages
  • I have updated the documentation accordingly
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional information for reviewer

Mention if this PR is part of any design or a continuation of previous PRs

@anurag-rajawat anurag-rajawat marked this pull request as ready for review May 27, 2024 03:54
@anurag-rajawat anurag-rajawat marked this pull request as draft May 27, 2024 04:11
@anurag-rajawat anurag-rajawat marked this pull request as ready for review May 27, 2024 08:47
shivaccuknox
shivaccuknox reviewed Jun 4, 2024
View reviewed changes
pkg/adapter/nimbus-k8tls/builder/builder.go Outdated Show resolved Hide resolved
pkg/adapter/nimbus-k8tls/builder/builder.go Show resolved Hide resolved
pkg/adapter/nimbus-k8tls/manager/manager.go Show resolved Hide resolved
pkg/adapter/nimbus-k8tls/manager/manager.go Outdated Show resolved Hide resolved
pkg/adapter/nimbus-k8tls/manager/manager.go Outdated Show resolved Hide resolved
pkg/adapter/nimbus-k8tls/manager/manager.go Outdated Show resolved Hide resolved
pkg/adapter/nimbus-k8tls/manager/manager.go Outdated Show resolved Hide resolved
pkg/adapter/nimbus-k8tls/manager/cronjob.go Outdated Show resolved Hide resolved
@shivaccuknox shivaccuknox self-requested a review June 10, 2024 16:45
shivaccuknox
shivaccuknox previously approved these changes Jun 10, 2024
View reviewed changes
@anurag-rajawat
CI: Add nimbus-k8tls job
ac5ce4a 
Signed-off-by: Anurag Rajawat <[email protected]>
This was referenced Jun 18, 2024
Open
Open
@shivaccuknox shivaccuknox merged commit 52c3aba into 5GSEC:main Jun 18, 2024
12 checks passed
@anurag-rajawat anurag-rajawat deleted the feat-k8tls-adapter branch June 21, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivaccuknox shivaccuknox shivaccuknox approved these changes

@VedRatan VedRatan Awaiting requested review from VedRatan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

k8tls Adapter
2 participants
@anurag-rajawat @shivaccuknox