-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/metrics reporting #56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etrics reporting and consumption reporting across different controllers
…ReportingController
…sReporting # Conflicts: # app/src/main/java/com/fivegmag/a5gmsmediasessionhandler/MediaSessionHandlerMessengerService.kt
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for QoE Metrics Reporting. In addition, it refactors the code to make it more modular, use dependency injection and introduce a more clear separation of concerns.
MediaSessionHandlerMessengerService
only acts as an entry point after an IPC message from the Media Stream Handler has been received. It calls the right controller class to perform the necessary actions.QoeMetricsReportingController
requests QoE metrics reports from the MediaStreamHandler and sends them via M5 to the AFQoeMetricsReportingController
andConsumptionReportingController
extendReportingController
which is implemented as an abstract class. That way, common functionality and required methods are shared acrossReportingController
classes.SessionController
acts as a controller for media streaming sessions initiating playback and download of ServiceAccessInformation (viaServiceAccessInformationController
).Eventbus
to implement an observer pattern that allow subscriber classes to react to changes dispatched by publisher classes. As an example. theServiceAccessInformationController
dispatches a notification once the ServiceAccessInformation has been updated to allow theConsumptionReportingController
to react to these changes.Example of a report as generated by version 1.2.0: