#143 light executed script #163
Conversation
- listExecutedScripts() now returns a sequence of LightExecutedScript - dependencies modified in consequence
There was a problem hiding this comment.
I'm not so sure about reading the identifiers. They are used during the scripts execution to determine in what order the scripts should be played but are there relevant otherwise?
Since the objective here is to serialize ExecutedScript and only read LightExecutedScript, I think the code to map executed scripts db to executed scripts could be removed and no code to serialize LightExecutedScript is necessary.
| script3, | ||
| script2 | ||
| lightScript3, | ||
| lightScript2 |
There was a problem hiding this comment.
Since ExecutedScript extends LightExecutedScript, shouldn't it work without even without giving explicit LightExecutedScript? Did you try?
There was a problem hiding this comment.
If it does not, maybe add an extension to ExecutedScript in the tests that creates the light executed script associated to a script (basically by casting it I think)
There was a problem hiding this comment.
No it does not work without explicit type.
There was a problem hiding this comment.
And casting is not enough.
There was a problem hiding this comment.
Then you could add a function extension to ExecutedScript, toLightExecutedScript(), in the tests. I'm sure it will help for other tests because MongoDriverTest should also check stuff like that.
| executionStatus, | ||
| action, | ||
| executionDurationInMillis, | ||
| executionOutput |
There was a problem hiding this comment.
Is this mapping function still necessary? It appears to me that only light executed scripts will be read from the database from now on
| name = name, | ||
| checksum = checksum, | ||
| identifier = identifier | ||
| ) |
There was a problem hiding this comment.
Is this function necessary? Light executed scripts should not be inserted in the database
| override fun serializeLightExecutedScript(lightExecutedScript: LightExecutedScript): String { | ||
| val lightExecutedScriptDb = lightExecutedScript.toLightExecutedScriptDb() | ||
|
|
||
| return mapper.stringify(LightExecutedScriptDb.serializer(), lightExecutedScriptDb) |
There was a problem hiding this comment.
Are light executed scripts serialized?
Add an extension function toLightExecutedScript() inside test to avoid lightScript variable in addition to script variable.
ExecutedScript are only serialized and LightExecutedScript are only deserialized.
#143
Add LightExecutedScript that only contains the name, checksum and identifier.
DatamaintainDriver.listExecutedScripts() now return a sequence of LightExecutedScripts instead of the full ExecutedScript.
Modified MongoDriver, JdbcDriver and tests accordingly.
@driccio