forked from openaire/guidelines-cris-managers
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the identifiers (the rest of cases that were not caught before) #2
Open
jdvorak001
wants to merge
33
commits into
4Science:issue-85
Choose a base branch
from
jdvorak001:issue-85-patch-2
base: issue-85
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISNI identifier moved to cerif-base-identifiers.xsd, used in person-identifiers.xsd and orgunit-identifiers.xsd
ROR -> RORID FundRefRegistry -> FundRefID
@lremy, many thanks for this!
instead of InterOutputRelations#Relation
- CERIF-TG-Tools - openaire-cris-validator
And uses the more fitting ElectronicAddress for organisations' websites.
* openaire#78 add the ./tools/compile.sh script and call it from .travis.yml * openaire#78 checkout also the necessary modules (CERIF-TG-Tools, openaire-cris-validator) * openaire#78 introduce an error to be discovered by the validator * openaire#78 corrects the error (and uses the more fitting ElectronicAddress for organisations' websites)
Conflicts: samples/openaire_cerif_xml_example_publications.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @abollini , there were still some naked numeric IDs left.
I am sorry, the checking command should have been
So I am suggesting the rest of the changes in this PR.
Referential integrity will be satisfied after applying this patch.