Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the identifiers (the rest of cases that were not caught before) #2

Open
wants to merge 33 commits into
base: issue-85
Choose a base branch
from

Conversation

jdvorak001
Copy link

Hello @abollini , there were still some naked numeric IDs left.
I am sorry, the checking command should have been

egrep -o 'id="[^"]*"' samples/openaire_*.xml | sort | uniq -c

So I am suggesting the rest of the changes in this PR.
Referential integrity will be satisfied after applying this patch.

Dragan Ivanovic and others added 30 commits November 29, 2019 12:18
ISNI identifier moved to cerif-base-identifiers.xsd, used in
person-identifiers.xsd and orgunit-identifiers.xsd
ROR -> RORID
FundRefRegistry -> FundRefID
instead of InterOutputRelations#Relation
- CERIF-TG-Tools
- openaire-cris-validator
And uses the more fitting ElectronicAddress for organisations' websites.
jdvorak001 and others added 3 commits November 20, 2020 14:06
* openaire#78 add the ./tools/compile.sh script and call it from .travis.yml
* openaire#78 checkout also the necessary modules (CERIF-TG-Tools, openaire-cris-validator)
* openaire#78 introduce an error to be discovered by the validator
* openaire#78 corrects the error (and uses the more fitting ElectronicAddress for organisations' websites)
Conflicts:
	samples/openaire_cerif_xml_example_publications.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants