Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MY_SELECTED and MINE orcid sync options #38

Open
wants to merge 4 commits into
base: dspace-cris-2023_02_x
Choose a base branch
from

Conversation

floriangantner
Copy link

@floriangantner floriangantner commented Jul 3, 2023

References

Add references/links to any related issues or PRs. These may include:

Description

Counterpart of PR 4Science/DSpace#351 for the frontend

Instructions for Reviewers

List of changes in this PR:

  • Added options MINE and MY_SELECTED
  • Messages are still/yet defined for these options
  • Added component tests for the changes options

Include guidance for how to test or review your PR.

  • Set up person profile with orcid
  • change values on the person profile orcid page. The values should be changed.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@floriangantner floriangantner marked this pull request as ready for review August 18, 2023 16:01
@floriangantner floriangantner changed the base branch from dspace-cris-7 to main-cris February 20, 2024 13:37
@floriangantner
Copy link
Author

aligned to 2023.02.02 release

@floriangantner floriangantner changed the base branch from main-cris to dspace-cris-2023_02_x April 9, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push selected publications to orcid
1 participant