Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 store is always enabled despite configuration #410

Closed
wants to merge 3 commits into from

Conversation

frabacche
Copy link

@frabacche frabacche commented Jan 18, 2024

Moved to: 9266

Description

S3 Store is always enabled regardless the value of the configuration assetstore.s3.enabled - but it should. This pull request contains the code to consider the configuration value in S3 store enabling.

Instructions for Reviewers

Java classes involved are just S3BitStoreService and S3BitStoreServiceIT - testing the correct initialization and enabling of the S3 Store feature.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@frabacche frabacche changed the title Duracom 211 s3store is always enabled S3 store is always enabled despite configuration Jan 18, 2024
@frabacche frabacche marked this pull request as ready for review January 25, 2024 09:01
@frabacche frabacche closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant