Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Stop using mambaforge in tests #1203

Merged
merged 1 commit into from
Oct 1, 2024
Merged

chore: Stop using mambaforge in tests #1203

merged 1 commit into from
Oct 1, 2024

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Oct 1, 2024

https://conda-forge.org/news/2024/07/29/sunsetting-mambaforge/

Summary by Sourcery

Update the GitHub Actions workflow to stop using the mambaforge variant in tests, following its deprecation.

CI:

  • Remove the use of the mambaforge variant in the GitHub Actions workflow for tests.

@Czaki Czaki added this to the 0.16.0 milestone Oct 1, 2024
Copy link
Contributor

sourcery-ai bot commented Oct 1, 2024

Reviewer's Guide by Sourcery

This pull request removes the use of mambaforge in the GitHub Actions workflow for tests. The change is made in response to the sunsetting of mambaforge, as announced by conda-forge.

No sequence diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removal of mambaforge variant in conda setup
  • Removed the 'miniforge-variant: mambaforge' line from the setup-miniconda action configuration
.github/workflows/tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

coderabbitai bot commented Oct 1, 2024

Walkthrough

The pull request introduces significant modifications to the GitHub Actions workflow file .github/workflows/tests.yml. It adds multiple jobs to enhance the testing framework, including checks for workflow issues, data downloading, and various testing strategies across different Python versions and operating systems. Additionally, it incorporates jobs for coverage reporting, package inspection, and environment setup, establishing a more structured and comprehensive testing process.

Changes

File Change Summary
.github/workflows/tests.yml Added jobs: actionlint, download_data, base-test, base-test-main, test_coverage, test_minimal, coverage_prepare, test_conda, check-package.

Poem

🐰 In the garden of code, we hop and play,
With tests and checks to brighten the day.
New jobs sprout up, like flowers in bloom,
Ensuring our package finds plenty of room.
So let’s dance in the fields of CI,
For every commit brings us closer to fly! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between b12d227 and 9a44f38.

📒 Files selected for processing (1)
  • .github/workflows/tests.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/tests.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarqubecloud bot commented Oct 1, 2024

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Czaki - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Czaki Czaki added the skip check PR title skip spellcheking PR title label Oct 1, 2024
@Czaki Czaki merged commit b0dd5ce into develop Oct 1, 2024
61 of 64 checks passed
@Czaki Czaki deleted the fix_miniforge branch October 1, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip check PR title skip spellcheking PR title
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant