New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reflect the the true initial state of a permission #33

Merged

43081j merged 3 commits into 43081j:main from TonySpegel:main

Aug 3, 2024

Contributor

TonySpegel commented Aug 1, 2024

fix issue Initial state of PermissionsController for geolocation doesn't seem to reflect its real state on pageload #32 by implicitly request an update
introduces a new (temporary) initital state: pending + type AsyncPermissionState
add a test: changes from pending to prompt

TonySpegel and others added 3 commits

August 1, 2024 16:49


          - implicitly request for an update to reflect the initial state

1973ab8

- add new initial pending state
- add documentation


          add test to simulate a change from pending to prompt

9850aec


          test: add change handler tests and simplify docs

c2fa107

43081j force-pushed the main branch from e2936df to c2fa107 Compare

August 3, 2024 11:05

43081j merged commit 0c9cdd1 into 43081j:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet