various improvements to attachment bridging #2172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, the urls were just appended to the message content. i couldn't find any other assignments directly to Extra["file"] anywhere in the codebase, so maybe there's a better way to do this.
many clients will only display files inline if the message body itself exactly matches the attachment URL. see https://docs.modernxmpp.org/client/protocol/#communicating-the-url
previously, the code assumed each file had a Data, and crashed if this was not present. now, we detect this condition, and send the URL instead. the discord client will display URLs in a message of their own as inline embeds, without any special behavior needed on our part. this commit makes the same changes to the webhook and non-webhook code.
|
Code Climate has analyzed commit ce93d90 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
briefly:
Extra["file"]please see the full commit messages for more detail.