[GGFE-243] 관리자 - 확성기 버튼 비활성화 추가 + 거래내역 테이블 수정 #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoouyeon
approved these changes
Sep 11, 2023
Comment on lines
+145
to
+148
| {megaphone.status === '삭제' || | ||
| megaphone.status === '사용 완료' | ||
| ? 'X' | ||
| : '삭제'} |
There was a problem hiding this comment.
megaphone.status 타입이 '삭제', '사용 완료', '사용 중', '사용 대기' 이렇게 4가지인건가요??
지금은 Imegaphone에 status가 string 타입인데 리터럴 타입으로 바꾸면 더 좋을 것 같아요!
There was a problem hiding this comment.
타입이 4가지로 고정되어 있으니 리터럴 타입이 더 좋겠군요. 감사합니다! 수정하겠습니다!
hyobb109
reviewed
Sep 11, 2023
| @@ -41,6 +41,14 @@ function ReceiptList() { | |||
| const [intraId, setIntraId] = useState<string>(''); | |||
| const setSnackBar = useSetRecoilState(toastState); | |||
|
|
|||
| const itemStatus: { [key: string]: string } = { | |||
There was a problem hiding this comment.
key를 string 대신 type ItemStatus = 'BEFORE' | 'WAITING' | 'USING' | 'USED' | 'DELETED' 이렇게 스트링 리터럴 타입으로 지정하면 좋을 것 같아요!
There was a problem hiding this comment.
여기도 있었네요! 감사합니다! 여기도 스트링 리터럴 타입으로 적용하겠습니다!
hyobb109
reviewed
Sep 11, 2023
| @@ -45,6 +45,10 @@ | |||
| border-radius: 8px; | |||
| justify-content: center; | |||
| align-items: center; | |||
| &:disabled { | |||
| cursor: not-allowed; | |||
There was a problem hiding this comment.
커서 속성에도 여러가지가 있네요! 새로운 것 배워갑니다👍
hyobb109
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
✅ 변경로직