Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GGFE-239] 트로피 이미지 + 확성기 기본문구 수정 #989

Merged
merged 5 commits into from
Sep 11, 2023
Merged

[GGFE-239] 트로피 이미지 + 확성기 기본문구 수정 #989

merged 5 commits into from
Sep 11, 2023

Conversation

PHJoon
Copy link
Contributor

@PHJoon PHJoon commented Sep 7, 2023

📌 개요

  • 트로피 이미지 + 확성기 기본문구 수정

💻 작업사항

  • 트로피 이미지 -> 데이터 이미지 속성 이름 다른 부분 수정
  • 확성기 기본 문구 -> 상점 아이템 설명에서 가져오는 것으로 수정

✅ 변경로직

@PHJoon PHJoon self-assigned this Sep 7, 2023
hyobb109
hyobb109 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@hyobb109 hyobb109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아이템 수정된거 잘 불러오고 랭크이미지도 이제 잘 나오네요! 고생하셨습니다👍

yoouyeon
yoouyeon approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

트로피 이미지 잘 나오고 확성기에 아이템 설명도 잘 보일 것 같네요!! 수고하셨습니다 😆👍

@PHJoon PHJoon merged commit 1eaa170 into main Sep 11, 2023
1 check passed
@PHJoon PHJoon deleted the GGFE-239-트로피-이미지-확성기-기본문구 branch September 11, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyobb109 hyobb109 hyobb109 approved these changes

@yoouyeon yoouyeon yoouyeon approved these changes

Assignees

@PHJoon PHJoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PHJoon @yoouyeon @hyobb109