[GGFE-236] 상점 구매, 선물 모달 api 에러 처리 #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHJoon
approved these changes
Sep 7, 2023
Comment on lines
41
to
44
| {item.imageUri ? ( | ||
| <Image src={item.imageUri} alt={item.itemName} fill /> | ||
| ) : ( | ||
| <Image src='/image/not_found.svg' alt={'not_found'} fill /> |
There was a problem hiding this comment.
<Image src={item.imageUri ? imageUri : '/image/not_founc.svg'} ... />
이렇게 쓸 수도 있을거 같아요.
이제 이미지 없으면 백에서 fallback uri 대신 null 보내주나요?
There was a problem hiding this comment.
확인해보니까 백에서는 null을 따로 막아두셨다고 해서, 에러났을 때 not_found 이미지 넣어달라고 요청드리면 될 것 같습니다! 그리고 next Image 에 onError로 이미지 경로 에러 시 처리 따로 추가해두었습니다😀
Comment on lines
+51
to
+58
| text-decoration-line: line-through; | ||
| text-decoration-color: #c03434; | ||
| text-decoration-style: solid; | ||
| text-decoration-thickness: 0.15rem; | ||
| -webkit-text-decoration-line: line-through; | ||
| -webkit-text-decoration-color: #c03434; | ||
| -webkit-text-decoration-style: solid; | ||
| -webkit-text-decoration-thickness: 0.15rem; |
yoouyeon
reviewed
Sep 8, 2023
| } else { | ||
| setError('HB03'); | ||
| } | ||
| } |
There was a problem hiding this comment.
요기도 else 블록 추가해서 setError('HB03'); 호출해줘야 할 것 같네요!
| } else { | ||
| setError('HB02'); | ||
| } | ||
| } |
There was a problem hiding this comment.
여기도 else 블록 추가해서 setError('HB02'); 호출해줘야 할 것 같아요!
There was a problem hiding this comment.
빠뜨릴 뻔했네요! 둘 다 수정했습니다! 꼼꼼하게 봐주셔서 감사합니다😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
그 외 수정 사항
✅ 변경로직