[GGFE-199] 관리자 상점관리 - 아이템 조회 수정 api 연결 #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoouyeon
approved these changes
Sep 6, 2023
components/admin/store/ItemList.tsx
Outdated
Comment on lines
93
to
97
| src={item[columnName]} | ||
| src={item.imageUri ? item[columnName] : ''} |
There was a problem hiding this comment.
이 부분에도 item.imageUri이 잘못된 값일 경우에 빈 문자열 대신 fallback image를 넣어주면 좋을 것 같아요!
hyobb109
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
✅ 변경로직