[GGFE-207] 확성기 등록 삭제 조회 api 연결 #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyobb109
reviewed
Sep 5, 2023
| .catch(() => { | ||
| // TODO : 에러 코드 정의 필요함. | ||
| alert('확성기 삭제에 실패했습니다.'); | ||
| .catch((error: unknown) => { |
There was a problem hiding this comment.
에러 나고 resetModal이 빠져서 계속 모달이 떠있네요! 그 부분만 추가하면 좋을 것 같습니다!
hyobb109
approved these changes
Sep 5, 2023
PHJoon
approved these changes
Sep 5, 2023
Comment on lines
+41
to
+45
| const errorMessages: Record<errorCodeType, string> = { | ||
| ME200: '확성기를 찾을 수 없습니다.', | ||
| RC500: '삭제할 수 없는 확성기입니다.', | ||
| RC200: '삭제할 수 없는 확성기입니다.', | ||
| }; |
Comment on lines
+72
to
+77
| if (isAxiosError<errorPayload>(error) && error.response) { | ||
| const { code } = error.response.data; | ||
| if (errorCode.includes(code) && code !== 'RC100') | ||
| alert(errorMessages[code]); | ||
| else setError('JY06'); | ||
| } else setError('JY06'); |
There was a problem hiding this comment.
에러가 axios에서 발생한 건지 확인할 수 있는 isAxiosError 란 게 있었군요! 배워갑니다! 👍
axios 최신 버전에서는 isAxiosError 함수를 따로 만들 필요 없이 사용해도 된다는데 저희 axios 버전 업데이트 하면 문제될까요?
There was a problem hiding this comment.
음... 잘 모르겠습니다 ㅎㅎㅜ 업데이트를 할까요?? 저도 업데이트를 하고 싶었는데 해도 될지 잘 모르겠어서 안했던것이거든요..! ㅜㅜ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
이 브랜치에는 아직 상점 조회 api가 연결되어 있지 않기 때문에 확성기 구매는 GGFE-215 브랜치에서 구매하시는 것 추천드립니다. ^_^
최대한 에러 코드에 맞게 alert를 보이도록 했는데 문구가 어색하면 말씀해주세요!
✅ 변경로직