Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GGFE-195] 상점 - 구매, 선물 모달 api 연결 #968

Merged
merged 6 commits into from
Aug 31, 2023
Merged

[GGFE-195] 상점 - 구매, 선물 모달 api 연결 #968

merged 6 commits into from
Aug 31, 2023

Conversation

hyobb109
Copy link
Member

@hyobb109 hyobb109 commented Aug 30, 2023 •
edited
Loading

📌 개요

  • 상점 - 구매, 선물 모달 api 연결

💻 작업사항

  • 구매, 선물 모달 api 연결했습니다
  • 노티 타입에 GIFT 추가했습니다
  • ItemType 변경 사항 반영했습니다

✅ 변경로직

@hyobb109 hyobb109 self-assigned this Aug 30, 2023
yoouyeon
yoouyeon approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구매하기, 선물하기, 선물 받았을 때 알림도 모두 잘 오네요! 수고하셨습니당 😆👍

PHJoon
PHJoon approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@PHJoon PHJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구매하기, 선물하기 다 잘 작동하는 것 확인했습니다!! 구매 후 스웨거로 확인하니 보관함에 잘 들어오네요! 알림도 잘 작동합니다! 고생하셨습니다!! 👍👍

parksangmin1543
parksangmin1543 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@parksangmin1543 parksangmin1543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

연결된 부분 확인했습니다. 구매후 코인변화량이 변화가 없어 구매후 새로고침을 하는 방식으로 변화량을 알수 있었으면 좋을것 같아요.

@hyobb109 hyobb109 merged commit f08b64e into main Aug 31, 2023
1 check passed
@hyobb109 hyobb109 deleted the GGFE-195-Store-API-Test branch August 31, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parksangmin1543 parksangmin1543 parksangmin1543 approved these changes

@PHJoon PHJoon PHJoon approved these changes

@yoouyeon yoouyeon yoouyeon approved these changes

Assignees

@hyobb109 hyobb109

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyobb109 @yoouyeon @PHJoon @parksangmin1543