-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] usepagenation 적용, 버그 및 css 수정 #1498 #1502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
받아오는 데이터 형식이 pagenation으로 변경되어 기능들이 작동이 잘 되지 않았었는데 그에 맞추어 잘 수정된 것 같아요~~ LGTM! 자잘한 부분들도 수정되어 좋습니당◡̈
@@ -3,6 +3,7 @@ import { AgendaDataProps } from 'types/agenda/agendaDetail/agendaTypes'; | |||
import { showPeriod, fillZero } from 'utils/handleTime'; | |||
import AgendaTag from 'components/agenda/utils/AgendaTag'; | |||
import styles from 'styles/agenda/Home/AgendaInfo.module.scss'; | |||
import { isSoloTeam } from '../utils/team'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상대경로
import { AgendaInfoProps } from 'types/agenda/agendaDetail/tabs/agendaInfoTypes'; | ||
import { AgendaStatus } from 'constants/agenda/agenda'; | ||
import { ShareBtn } from 'components/agenda/button/Buttons'; | ||
import { UploadBtn } from 'components/agenda/button/UploadBtn'; | ||
import styles from 'styles/agenda/agendaDetail/AgendaInfo.module.scss'; | ||
import { isSoloTeam } from '../utils/team'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상대경로
export function isSoloTeam(minPeople: number, maxPeople: number) { | ||
return maxPeople === 1 && minPeople === 1; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이전에 제대로 처리되지 않은 부분 수정해주셔서 감사합니당 ㅎㅎ
@@ -2,25 +2,22 @@ import { ParticipantTabProps } from 'types/agenda/agendaDetail/tabs/participantT | |||
import ParticipantsList from 'components/agenda/agendaDetail/tabs/ParticipantsList'; | |||
import styles from 'styles/agenda/agendaDetail/tabs/AgendaParticipants.module.scss'; | |||
import ParticipantTeamList from './ParticipantTeamList'; | |||
import { isSoloTeam } from '../../utils/team'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상대경로
hooks/agenda/usePageNation.ts
Outdated
fetchData(); | ||
}); | ||
if (!status.current || status.current / 100 != 2) fetchData(); | ||
console.log(url); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log~
…into Feat/#1498-usepagenation-apply-bug-css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
참여자, 공지사항 등의 map 에러들이 paegnation 코드로 인해 에러가 발생했었는데, 확인해보니 모두 정상 작동되는 것을 확인했습니다! LGTM! 👍
넵 콘솔로그 / 상대경로 처리하는 김에 겸사겸사 다 처리했습니다~! 감사합니다 |
📌 개요
💻 작업사항
usePageNation 사용법
계속 호출하는 문제: api 호출 조건 제한을 통해 해결
size, currentPage 변경 시 자동 호출
또한 다른 이유로 불렸을 경우에도 이전 호출 성공했을 경우 (200번대 status) 호출하지 않음
css
💡관련 Issue