Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] left pages #1484 #1490

Merged
merged 22 commits into from
Aug 21, 2024
Merged

[Feat] left pages #1484 #1490

merged 22 commits into from
Aug 21, 2024

Conversation

cweedlee
Copy link
Collaborator

@cweedlee cweedlee commented Aug 20, 2024

πŸ“Œ κ°œμš”

  • 인덱슀 및 ν‹°μΌ“ νŽ˜μ΄μ§€ μž‘μ—…

πŸ’» μž‘μ—…μ‚¬ν•­

인덱슀 νŽ˜μ΄μ§€

  • νŽ˜μ΄μ§€ μ—°κ²°λ§Œ λ˜μ–΄μžˆμŒ
  • μΊλŸ¬μ…€ κΈ°λŠ₯ μΆ”κ°€( μžλ™λ„˜κΉ€, ν˜Έλ²„ μ‹œ ν™”μ‚΄ν‘œ λ“±μž₯)
Screen.Recording.2024-08-20.at.3.21.33.PM.mov

ν‹°μΌ“ νŽ˜μ΄μ§€

  • ν‹°μΌ“ api μ—°κ²° 및 UI μ™„λ£Œ
  • ν‹°μΌ“λ°œκΈ‰ μ™„λ£Œμ˜ 경우 500 λœ¨κΈ°λ•Œλ¬Έμ— λ°±μ—”λ“œ μͺ½μ— 확인 ν•„μš”
  • λ°œκΈ‰λ‚΄μ—­μ˜ 경우 μ „λΆ€ λ‹€ λ„μš°μ§€ μ•Šκ³  μ‚¬μš©μžκ°€ λ³Ό ν•„μš”κ°€ μžˆλ‹€κ³  μƒκ°ν•˜λŠ” ν•­λͺ©λ§Œ κΈ°μž¬ν•¨
Screenshot 2024-08-20 at 2 33 23β€―PM Screenshot 2024-08-20 at 2 34 57β€―PM

ν‹°μΌ“ νŽ˜μ΄μ§€ μ‚¬μš©μ²˜ μˆ˜μ •

  • 전체 리슀트 λ§ˆμ΄μ•„μ  λ‹€ 였λ₯Έμͺ½ μ •λ ¬μœΌλ‘œ μˆ˜μ • - λ””μžμΈ μ •λ ¬λ¬Έμ œ
  • ν‹°μΌ“ νŽ˜μ΄μ§€ λ‚΄λΆ€μ—μ„œλ§Œ λ°œκΈ‰ κ°€λŠ₯ν•˜κ²Œ μ œμž‘
Screenshot 2024-08-20 at 2 32 56β€―PM Screenshot 2024-08-20 at 2 35 21β€―PM

@cweedlee cweedlee linked an issue Aug 20, 2024 that may be closed by this pull request
5 tasks
@cweedlee cweedlee changed the base branch from main to agenda August 20, 2024 06:52
@JeongRon JeongRon changed the title Feat/#1484 left pages [Feat] left pages #1484 Aug 21, 2024
Copy link
Contributor

@irenee-14 irenee-14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ§§μ€μ‹œκ°„μ— index νŽ˜μ΄μ§€μ™€ ν‹°μΌ“ λ°œκΈ‰ νŽ˜μ΄μ§€κΉŒμ§€ λ§Œλ“œμ‹ κ±° λŒ€λ‹¨ν•΄μš”...! LGTM~~ μ½”λ©˜νŠΈ λ‚¨κΈ°λŠ” 뢀뢄은 μ§€κΈˆ κ³ μΉ˜κ³ κ³„μ‹œλ‹ˆ μˆ˜μ • ν›„ λ‹€μ‹œ PR λΆ€νƒλ“œλ €μš”~~

<h1 className={styles.h1}>λ‚΄ ν‹°μΌ“</h1>
<div className={styles.ticketSection}>
<div className={styles.ticketFrame}>
<h1>{data && data.ticketCount}</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ°œκΈ‰ μ™„λ£Œλ§Œ λˆŒλŸ¬λ„ ν‹°μΌ“ κ°œμˆ˜κ°€ λŠ˜μ–΄λ‚˜λŠ” λΆ€λΆ„ λ°±μ—”λ“œμͺ½μ— ν™•μΈν•„μš”!

return (
<div>
<TicketHistory data={content} />
<PageNation {...PagaNationElementProps} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pagenation λ˜λ©΄μ„œ 같은 apiλ₯Ό 반볡적으둜 ν‘œμ‹œλ˜λŠ” λΆ€λΆ„ ν™•μΈν•΄μ£Όμ„Έμš”~

Copy link
Contributor

@JeongRon JeongRon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

첫 인덱슀 νŽ˜μ΄μ§€ / ν‹°μΌ“ λ°œκΈ‰ νŽ˜μ΄μ§€ / μœ μ € ν”„λ‘œν•„μ˜ ν‹°μΌ“ UI λ“±μ˜ μƒˆλ‘œ μ œμž‘λœ νŽ˜μ΄μ§€μ™€ UI λ₯Ό ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€. ν”Όκ·Έλ§ˆλ‘œ μ œμž‘ ν•˜μ§€ μ•Šμ•˜λ˜ 뢀뢄듀인데 λ””μžμΈ + μ½”λ“œ κ΅¬ν˜„ν•˜λŠλΌ λ„ˆλ¬΄ 수고 λ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€! πŸ‘

@JeongRon JeongRon merged commit ff9fa04 into agenda Aug 21, 2024
@cweedlee cweedlee deleted the Feat/#1484-left-pages branch August 29, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 남은 νŽ˜μ΄μ§€(index, ticket) λ§Œλ“€κΈ°
3 participants