Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] css 스타일 통일 #1458 #1459

Merged
merged 10 commits into from
Jul 26, 2024
Merged

[Feat] css 스타일 통일 #1458 #1459

merged 10 commits into from
Jul 26, 2024

Conversation

cweedlee
Copy link
Collaborator

📌 개요

  • css 스타일을 통일했습니다.

💻 작업사항

  • mixin으로 통일한 부분 : 텍스트 스타일, 컨테이너

  • 변수 통일: 텍스트 사이즈 등

  • 변수명 통일: {css-property}-{value}

  • 이하 개정된 기준에 따라 정리

@cweedlee cweedlee linked an issue Jul 25, 2024 that may be closed by this pull request
[Feat] 스타일 통일 #1458
Closed
@cweedlee cweedlee changed the base branch from main to agenda July 25, 2024 05:32
irenee-14
irenee-14 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@irenee-14 irenee-14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

css mixin등이 통일되어 아주 좋습니다👍 자잘한 오류들도 수정된 것을 확인했습니다!

JeongRon
JeongRon approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@JeongRon JeongRon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적인 css 통일을 해서 좋네요! 👍

@cweedlee cweedlee merged commit 6503af9 into agenda Jul 26, 2024
@cweedlee
Copy link
Collaborator Author

[Feat] css 스타일 통일 #1458
모두 스타일 잡은 부분 확인했습니다. 앞으로도 까먹지 말고 common.scss 참고하기 ~

@irenee-14 irenee-14 deleted the Feat/#1458-css-style-unify branch August 29, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeongRon JeongRon JeongRon approved these changes

@irenee-14 irenee-14 irenee-14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 스타일 통일
3 participants
@cweedlee @irenee-14 @JeongRon