Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] agenda list layout #1437 #1451

Merged
merged 18 commits into from
Jul 18, 2024
Merged

[Feat] agenda list layout #1437 #1451

merged 18 commits into from
Jul 18, 2024

Conversation

JeongRon
Copy link
Contributor

@JeongRon JeongRon commented Jul 18, 2024 •
edited
Loading

πŸ“Œ κ°œμš”

  • Agenda 첫 νŽ˜μ΄μ§€ λ ˆμ΄μ•„μ›ƒ μž‘μ—…

πŸ’» μž‘μ—…μ‚¬ν•­

스크란샷 2024-07-18 α„‹α…©α„Œα…₯ᆫ 10 41 21

Component λΆ„λ₯˜

  1. AgendaTitle -> Agenda 타이틀 + κ°œμ΅œμ‹ μ²­ λ²„νŠΌ
  2. MyAagenda -> 클릭 μ‹œ, λ‚΄κ°€ μ‹ μ²­ν•œ μ•„μ  λ‹€ λͺ©λ‘ λͺ¨λ‹¬ 띄어짐 (λ‹€μŒ μ˜ˆμ •)
  3. AgendaList -> μ•„μ  λ‹€ λͺ©λ‘λ“€

체크 사항

  • μ œκ°€ λ§ˆμ§€λ§‰μœΌλ‘œ 병합을 ν•΄μ„œ κ³΅ν†΅λœ λΆ€λΆ„ common.scss, globlas.css 등이 μ˜λ„μΉ˜ μ•Šμ€ 변경이 μΌμ–΄λ‚¬λŠ”μ§€ ν™•μΈν•΄μ£Όμ„Έμš”!
  • Link νƒœκ·Έλ₯Ό μΆ”κ°€ν•΄μ„œ 'μ•„μ  λ‹€ 생성, λŒ€νšŒμƒμ„Έ' νŽ˜μ΄μ§€λ‘œ url을 이동할 수 있게 μ„€μ •ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ’‘κ΄€λ ¨ Issue

@JeongRon
[Fix] css 문법 였λ₯˜ μˆ˜μ •
2eb175d
@JeongRon
[Feat] 11StreetGothic 폰트 μΆ”κ°€
d970ce8 
- μŠ€ν† λ¦¬λΆμ—λ„ 적용 κ°€λŠ₯ν•˜κ²Œλ„ μ„€μ •
@JeongRon
[Feat] μ•„μ  λ‹€ νŽ˜μ΄μ§€ reset.css μ„€μ •
83e1180
@JeongRon
[Feat] 11λ²ˆκ°€ 폰트 - bold, light μΆ”κ°€
9f507d7
@JeongRon
[Feat] font μ„€μ •
505d82f
@JeongRon
[Feat] Agenda - AgendaTitle, MyAgenda μ»΄ν¬λ„ŒνŠΈ μ œμž‘
775b6c0
@JeongRon
[Feat] AgendaTitle, MyAgendaBtn 벑터 이미지 μΆ”κ°€ 및 적용
818a845
@JeongRon
[Feat] AgendaList Component
7ecd4bd
@JeongRon
[Feat] AgendaList 이미지 μΆ”κ°€ 및 적용
409d43d
@JeongRon
[Feat] DeadLineBox UI μΆ”κ°€
3f71b5e
@JeongRon
[Style] agendaListItemBtn λ°±κ·ΈλΌμš΄λ“œ μ„€μ •
45d46de
@JeongRon
[Fix] AgendaList 이미지 μ•„μ΄μ½˜ λ³€κ²½ 및 적용
a5af942
@JeongRon
[Feat] Agenda Page Storybook
c509e73
@JeongRon
Merge branch 'agenda' into Feat/#1437-agenda-list-layout
c9cc094
@JeongRon
[Feat] νŒ€μ› μž‘μ—…κ³Ό ν•©μΉ˜κΈ°
0e246c0 
- Link νƒœκ·Έ ν†΅ν•΄μ„œ ν΄λ¦­μ‹œ, νŒ€μ›μ΄ λ§Œλ“  νŽ˜μ΄μ§€ (μ•„μ  λ‹€ 생성, λŒ€νšŒ 상세) 이동 ν•˜κ²Œ μ„€μ •
@JeongRon JeongRon added the enhancement New feature or request label Jul 18, 2024
@JeongRon JeongRon self-assigned this Jul 18, 2024
@JeongRon JeongRon linked an issue Jul 18, 2024 that may be closed by this pull request
[Feat] agenda list λ ˆμ΄μ•„μ›ƒ #1437
Closed
3 tasks
@JeongRon JeongRon changed the base branch from main to agenda July 18, 2024 04:40
irenee-14
irenee-14 reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@irenee-14 irenee-14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

각 μ»΄ν¬λ„ŒνŠΈ λ³„λ‘œ λΆ„λ¦¬λ§Œ 잘 이루어지면 쒋을 것 κ°™μ•„μš”!

components/agenda/Home/AgendaList.tsx Outdated Show resolved Hide resolved
components/agenda/Home/AgendaList.tsx Outdated Show resolved Hide resolved
components/agenda/Home/AgendaList.tsx
);
};

const AgendaListBtn = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

각 μ•„μ  λ‹€ ν•­λͺ©λ“€λ„ 파일 λΆ„λ¦¬ν•΄λ’€μœΌλ©΄ μ’‹κ² μŠ΅λ‹ˆλ‹€~

irenee-14
irenee-14 reviewed Jul 18, 2024
View reviewed changes
.github/PULL_REQUEST_TEMPLATE.md
Comment on lines +8 to +23

## πŸ“Œ κ°œμš” <!-- PRλ‚΄μš©μ— λŒ€ν•΄ μΆ•μ•½ν•΄μ„œ μ μ–΄μ£Όμ„Έμš”. -->

-

## πŸ’» μž‘μ—…μ‚¬ν•­ <!-- PRλ‚΄μš©μ— λŒ€ν•΄ 상세섀λͺ…이 ν•„μš”ν•˜λ‹€λ©΄ 이 뢀뢄에 기재 ν•΄μ£Όμ„Έμš”. -->

-

## βœ… λ³€κ²½λ‘œμ§ <!-- 고친 사항을 μ μ–΄μ£Όμ„Έμš”. 재PR μ‹œμ—λ§Œ μ‚¬μš©ν•΄ μ£Όμ„Έμš”! (재PR μ•„λ‹Œ 경우 μ‚­μ œ) -->

-

## πŸ’‘κ΄€λ ¨ Issue <!-- κ΄€λ ¨ Issue 번호λ₯Ό κΈ°λ‘ν•΄μ£Όμ„Έμš”. closeκ°€ ν•„μš”ν•œ κ²½μš°μ—λŠ” close #[이슈번호]λ₯Ό ν•΄μ£Όμ„Έμš” -->

-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전 파일둜 λ³€κ²½ λΆ€νƒλ“œλ¦½λ‹ˆλ‹€~

.storybook/preview.tsx Outdated Show resolved Hide resolved
cweedlee
cweedlee approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@cweedlee cweedlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ΅Ώκ΅Ώμž…λ‹ˆλ‹Ή

public/image/agenda/Vector.svg Outdated Show resolved Hide resolved
@cweedlee
Copy link
Collaborator

cweedlee commented Jul 18, 2024 •
edited
Loading

λΉŒλ“œ μ•ˆλ€ λΆ€λΆ„ μ œκ°€ ν•œ 뢀뢄이라 ν™•μΈν•˜κ³  μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
μ‚¬μœ :
alert() λ§€κ°œλ³€μˆ˜ console.log처럼 μ—¬λŸ¬κ°œλ„£μ„ 수 μžˆλŠ” 쀄 μ•Œμ•˜μŠ΅λ‹ˆλ‹€..
그리고 μ œκ°€ 올릴 λ•ŒλŠ” μ—λŸ¬λ‚˜μ„œ κ·Έλƒ₯ μ˜¬λΌκ°„ κ±° κ°™μ•„μš” μŠ€ν† λ¦¬λΆμ€ μ•ˆμž‘μ•„μ£Όλ‹ˆκΉŒ... 쑰심...

@JeongRon
[Fix] ν”Όλ“œλ°± 반영
7ea1abf 
- Vector.svg 이름 λ³€κ²½ (ArrowRIght.svg)
- AgendaTag : 이름 넣을 μ‹œ, # μ œμ™Έν•΄μ„œ λ„£κΈ° + μ»΄ν¬λ„ŒνŠΈ λ”°λ‘œ λΆ„λ₯˜
cweedlee
cweedlee approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@cweedlee cweedlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜μ •μ‚¬ν•­ 반영된 λΆ€λΆ„ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.

components/agenda/utils/AgendaTag.tsx
tagName: string;
}

const AgendaTag: React.FC<AgendaTagProps> = ({ tagName }) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ§Œμ•½μ— λ‚˜μ€‘μ— μ—¬λŸ¬λ²ˆ μž¬μ‚¬μš©ν•˜κ²Œ 되면 색은 λ³€μˆ˜λ‘œ 빼놓아도 쒋을것 κ°™μŠ΅λ‹ˆλ‹€. (μ§€κΈˆ κ·ΈλŸ¬μžλŠ” λœ»μ€ μ•„λ‹™λ‹ˆλ‹€)

@cweedlee cweedlee merged commit f484dec into agenda Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irenee-14 irenee-14 irenee-14 left review comments

@cweedlee cweedlee cweedlee approved these changes

Assignees

@JeongRon JeongRon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] agenda list λ ˆμ΄μ•„μ›ƒ
3 participants
@JeongRon @cweedlee @irenee-14