Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] set common css #1436 #1443

Merged
merged 4 commits into from
Jul 9, 2024
Merged

[Fix] set common css #1436 #1443

merged 4 commits into from
Jul 9, 2024

Conversation

cweedlee
Copy link
Collaborator

@cweedlee cweedlee commented Jul 8, 2024

๐Ÿ“Œ ๊ฐœ์š”

  • nextjs์—์„œ ๋นŒ๋“œ ์•ˆ๋ผ์„œ ๋ฐ”๋กœ ๊ณ ์ณ์™”์Šต๋‹ˆ๋‹ค
  • color-theme.css ๋‚ด ๋ณ€์ˆ˜๋ช… ํ™•์ธํ•ด์„œ var($--๋ณ€์ˆ˜๋ช…)์“ฐ์‹œ๋ฉด ๋ฉ๋‹ˆ๋‹ค(์ผ๋‹จ)
  --color-bg : ๋ฐฐ๊ฒฝ์ƒ‰
  --color-text : ๊ธฐ๋ณธ ํ…์ŠคํŠธ ์ปฌ๋Ÿฌ
  --default-border: ๊ธฐ๋ณธ ๋ณด๋”
  --default-box-shadow: ๊ธฐ๋ณธ ๋ฐ•์Šค์‰๋„์šฐ^^
  --highlight-yellow: ๊ฐ•์กฐ-๋…ธ๋ž‘
  --highlight-violet: ๊ฐ•์กฐ-๋ณด๋ผ
  --box-bg-1: ํšŒ์ƒ‰ 1
  --box-bg-2: ์•„๋ž˜๋กœ๊ฐˆ์ˆ˜๋ก
  --box-bg-3: ์ง„ํ•œ ํšŒ์ƒ‰^^
  • ํ•„์š”ํ•œ ๊ฑฐ ์žˆ์œผ๋ฉด ์ถ”๊ฐ€ํ•ด์„œ ์“ฐ์„ธ์—ฌ

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • ๋นŒ๋“œ ์•ˆ๋€ ์ด์œ ๋Š” -> next.js + scss์—์„œ html[data-theme]๋กœ ๋ณ€์ˆ˜์„ค์ •ํ•˜๋Š” ๊ฑธ ์ง€์›ํ•˜์ง€ ์•Š์•˜๊ธฐ ๋•Œ๋ฌธ
  • ๊ทธ๋ž˜์„œ global.css ์˜†์— color-theme.css ๋”ฐ๋กœ ๋นผ์„œ ์˜ฌ๋ ค๋†จ์–ด์š”...

nextjs์—์„œ ๋‹คํฌ๋ชจ๋“œ ๊ตฌํ˜„ํ•  ๋•Œ ์ข€ ๊ณ ๋ คํ•  ์‚ฌํ•ญ์ด ๋งŽ์€ ๋“ฏ
https://abangpa1ace.tistory.com/entry/%EC%9E%91%EC%84%B1%EC%A4%91Nextjs-Dark-Mode-%EA%B5%AC%ED%98%84%ED%95%98%EA%B8%B0
ssr์ด๋ผ๋˜๊ฐ€ useTheme๋ฅผ ํ†ตํ•ด์„œ ๋กœ์ปฌ์—๋„ ์ €์žฅํ•˜๊ณ  ํ•˜๋Š” ๋ถ€๋ถ„์ด๋ผ๋˜๊ฐ€..

useTheme๋Š” ์ œ๊ฐ€ ๋˜ ๋งŒ๋“ค์–ด์„œ ์ถ”๊ฐ€ํ•ด ๋‘๊ฒ ์Šต๋‹ˆ๋‹ค...

@cweedlee cweedlee linked an issue Jul 8, 2024 that may be closed by this pull request
[Feat] ๊ณตํ†ต scss ์„ธํŒ… #1436
Closed
@cweedlee cweedlee changed the base branch from main to agenda July 8, 2024 08:28
irenee-14
irenee-14 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@irenee-14 irenee-14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทธ๋ž˜๋„ ๊ณ„์† ํ•ด๊ฒฐ์ฑ…์„ ์ฐพ์•„์™€์„œ ๋ฉ‹์ ธ์š”...! ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹น ํ•œ๋ฒˆ ์ ์šฉํ•ด๋ณผ๊ฒŒ์š”! LGTM~~

@cweedlee cweedlee merged commit fd61429 into agenda Jul 9, 2024
@cweedlee cweedlee deleted the Feat/set-common-css-#1436 branch July 9, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irenee-14 irenee-14 irenee-14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] ๊ณตํ†ต scss ์„ธํŒ…
2 participants
@cweedlee @irenee-14