-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Others] 예정 진행중 토너먼트 데이터 fetching 리팩토링 #1024 #1218
Merged
The head ref may contain hidden characters: "others/\uC608\uC815-\uC9C4\uD589\uC911-\uD1A0\uB108\uBA3C\uD2B8-\uB370\uC774\uD130-fetching-\uB9AC\uD329\uD1A0\uB9C1-#1024"
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers/토너먼트-브라켓-승자-패자-구분-ui-#1173
…4-others-예정-진행중-토너먼트-데이터-fetching-리팩토링
Clearsu
added
user
일반 사용자가 사용하는 서비스에서 발생한 issue
refactor
유지보수와 잠재적 오류를 방지하기 위한 refactor issue
labels
Dec 27, 2023
greatSweetMango
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
useBeforeLiveTournamentData
커스텀훅에서 예정 및 진행중인 토너먼트 배열을 분리하여 받을 수 있도록 수정하여 메인 페이지 및 토너먼트 페이지에서 재사용할 수 있도록 리팩토링하였습니다.useBeforeLiveTournamentData
훅으로 대체하였습니다.TournamentPreviewItem
컴포넌트를 삭제하고, 디렉토리 구조를 변경하였습니다.