Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoouyeon
approved these changes
Sep 14, 2023
Comment on lines
27
to
28
| height: 50vh; | ||
| max-height: 50vh; |
There was a problem hiding this comment.
둘 중 하나만 적용해도 될 것 같아요!! (height만 적용하면 되지 않을까 싶습니당)
There was a problem hiding this comment.
지금 보니까 살짝 꽉 차는 듯한 느낌이 있어서 45vh 정도로 해도 괜찮을 것 같은데 어떠신가요?
There was a problem hiding this comment.
하나만 적용해도 잘 되군요! 45vh로 수정 적용했습니다! 감사합니다!
Comment on lines
27
to
28
| height: 50vh; | ||
| max-height: 50vh; |
There was a problem hiding this comment.
여기도 동일하게 45vh 정도 해도 괜찮을 것 같아요!
hyobb109
reviewed
Sep 14, 2023
| } | ||
|
|
||
| .title { | ||
| margin: 2.75rem 0; | ||
| margin-bottom: 1.5rem; |
There was a problem hiding this comment.
위에 padding-top, padding-bottom이랑 title의 margin-bottom 2rem 정도로 해도 좋을 것 같아요!
There was a problem hiding this comment.
간격 더 있는게 좋네요! 감사합니다!
hyobb109
reviewed
Sep 14, 2023
| } | ||
|
|
||
| .title { | ||
| margin: 2.75rem 0; | ||
| margin-bottom: 1.5rem; |
There was a problem hiding this comment.
여기도 매치 매뉴얼에 코멘트 단 거랑 똑같이 2rem 해도 좋을 것 같습니다!
hyobb109
approved these changes
Sep 14, 2023
|
위 피드백 받은 사항들 다 수정했습니다!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
✅ 변경로직