-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GGFE-245] 상점 css 보완 및 배경, 엣지 스타일 문법 수정 #1004
The head ref may contain hidden characters: "GGFE-245-\uC0C1\uC810-CSS-\uBCF4\uC644"
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다! each문 쓰니까 훨씬 보기 좋고 이해하기도 쉽네요! 코인 내역 콤마도 잘 들어가있고 단어 줄바꿈도 잘 되네요! 고생하셨습니다! 👍
@each $theme, $color in $bg-theme-colors { | ||
&.#{$theme} { | ||
background: map-get($map: $color, $key: 'background'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이렇게 간단히 표현할 수 있군요 😮 scss 반복문 배워갑니다!
엣지, 배경 색상 확정된거로 수정 후 다시 pr 올리겠습니다! |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
배경 색/이미지띠 색 확정해서 너무 좋네요....ㅎㅎㅎ
변수명 바꾸니까 훨씬 보기 좋은 것 같아요! 반복문으로 고친 것도 훨씬 읽기 쉬워진 것 같구요!
수정하신 다른 부분도 모두 잘 되는 것 같습니당 수고하셨어요!! 😆👍
📌 개요
💻 작업사항
✅ 변경로직