Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow customization of the response #177

Merged
merged 7 commits into from
Mar 8, 2024

Conversation

42atomys
Copy link
Owner

@42atomys 42atomys commented Mar 7, 2024

Describe the pull request

This pull request introduce the possibility to set the response of the webhook per spec using the formatting feature already present in the app.

Checklist

  • I have linked the relative issue to this pull request
  • I have made the modifications or added tests related to my PR
  • I have added/updated the documentation for my RP
  • I put my PR in Ready for Review only when all the checklist is checked

Breaking changes ?
no

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 84.12698% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 93.86%. Comparing base (90c7e8c) to head (3b7b608).
Report is 3 commits behind head on main.

Files Patch % Lines
internal/config/configuration.go 28.57% 2 Missing and 3 partials ⚠️
internal/server/v1alpha1/handlers.go 82.14% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
- Coverage   94.11%   93.86%   -0.25%     
==========================================
  Files          22       22              
  Lines        1393     1435      +42     
==========================================
+ Hits         1311     1347      +36     
- Misses         56       60       +4     
- Partials       26       28       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@42atomys 42atomys requested a review from rgaiffe as a code owner March 8, 2024 00:24
@42atomys 42atomys merged commit eac6a23 into main Mar 8, 2024
9 of 11 checks passed
@42atomys 42atomys deleted the feat/response-customization branch March 8, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant