Level Grind : Fix leader leveling when it doesn't have any damaging moves #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibaultLassiaz
changed the title
ThibaultLassiaz
changed the title
hanzi
reviewed
Nov 18, 2024
modules/battle_strategies/_util.py
Outdated
| strongest_move = move_strengths.index(max(move_strengths)) | ||
| max_strength = max(move_strengths) | ||
| if max_strength <= 0: | ||
| raise BotModeError("No valid moves available! Check move setup or disable restrictions.") |
There was a problem hiding this comment.
'valid moves' might be a bit of a confusing phrase to users who don't know what we're checking for.
Maybe say "{pokemon.species.name} does not know any damage-dealing moves, or they are forbidden to use by bot configuration" instead?
modules/modes/_asserts.py
Outdated
| @@ -176,3 +176,17 @@ def assert_player_has_poke_balls() -> None: | |||
| else: | |||
| if get_item_bag().number_of_balls_except_master_ball == 0: | |||
| raise BotModeError("Out of Pokéballs! Better grab more before the next shiny slips away...") | |||
|
|
|||
|
|
|||
| def assert_leader_can_fight(pokemon: Pokemon) -> None: | |||
There was a problem hiding this comment.
Isn't that naming a bit inaccurate, if you have to pass the Pokémon-to-check yourself? 🤔
ThibaultLassiaz
force-pushed
the
fix-level-grind-lead-unusable-moves
branch
from
b5df19d
to
df53b25
Compare
ThibaultLassiaz
force-pushed
the
fix-level-grind-lead-unusable-moves
branch
from
df53b25
to
d96aea0
Compare
hanzi
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes for Level Grind Mode
This PR addresses two issues with leader leveling in level grind mode:
Starting with Unusable Moves: The mode would previously start even if the leader’s only moves were banned or had zero power, which made leveling ineffective because it couldn't kill opponent.
Incorrect Move Selection in
get_strongest_move_against: Previously, banned moves were excluded from the move pool usingcontinue, causing issues where a banned move might be selected if no other valid moves were available. For instance, if the first move was "False Swipe" (banned) and the other three moves were non-damaging, the bot would incorrectly default to using the banned move. Now, if all moves are either banned or non-damaging, an error is raised, preventing unintended behavior.Here is a Pokémon example that was causing the issue
(btw yes you can level grind a lvl 100 Pokémon)
Changes
Added an assert of level grind when chosing leveling leader only
Raising an error on
get_strongest_move_againstwhen no damaging move are availableNotes
Checklist
--line-length 120argument