Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix banned moves being used on battling #484

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

ThibaultLassiaz
Copy link
Contributor

Description

Banned moves like False swipe, self destruct etc are being used when battling. This prevent modes like level grind to work properly.

Changes

Skip banned moves when chosing strongest move against an opponent

Notes

Checklist

  • Black Linter has been ran, using --line-length 120 argument
  • Wiki has been updated (if relevant)

@pekempy
Copy link
Collaborator

pekempy commented Nov 3, 2024

Q: Has this been tested to ensure that self destruction is still utilised in Kecleon mode?

@ThibaultLassiaz
Copy link
Contributor Author

Q: Has this been tested to ensure that self destruction is still utilised in Kecleon mode?

I tested it, Kecleon mode uses a LoseOnPurposeStrategy which has its own implemented move selection. Thus, it is not affected by the ban list and uses self killing moves like selfdestruct or explosion.

@pekempy pekempy merged commit 78fe6fe into 40Cakes:main Nov 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants