EV Training ready for testing #447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/gui/ev_selection_window.py
Outdated
Comment on lines
49
to
54
| Label(window, text="HP").grid(row=0, column=1) | ||
| Label(window, text="Atk").grid(row=0, column=2) | ||
| Label(window, text="Def").grid(row=0, column=3) | ||
| Label(window, text="SpA").grid(row=0, column=4) | ||
| Label(window, text="SpD").grid(row=0, column=5) | ||
| Label(window, text="Spe").grid(row=0, column=6) |
There was a problem hiding this comment.
Mapping is wrong on the UI, causing data to be mapped to the wrong stats in the code. Here's the correct UI -> Code mapping
Label(window, text="HP").grid(row=0, column=1)
Label(window, text="Atk").grid(row=0, column=2)
Label(window, text="Def").grid(row=0, column=3)
Label(window, text="Spe").grid(row=0, column=4)
Label(window, text="SpA").grid(row=0, column=5)
Label(window, text="SpD").grid(row=0, column=6)
There was a problem hiding this comment.
This works, but it is in non-standard EV ordering. If you choose to implement this solution, please do not implement any of my suggested changes.
orchi
reviewed
Nov 11, 2024
modules/modes/ev_train.py
Outdated
| } | ||
|
|
||
|
|
||
| _list_of_stats = ("hp", "attack", "defence", "speed", "special_attack", "special_defence") |
There was a problem hiding this comment.
Change this to be in the standard EV order
Suggested change
| _list_of_stats = ("hp", "attack", "defence", "speed", "special_attack", "special_defence") | |
| _list_of_stats = ("hp", "attack", "defence", "special_attack", "special_defence", "speed") |
modules/gui/ev_selection_window.py
Outdated
| Label(window, text="SpD").grid(row=0, column=5) | ||
| Label(window, text="Spe").grid(row=0, column=6) | ||
|
|
||
| for stat in ("hp", "attack", "defence", "speed", "special_attack", "special_defence"): |
There was a problem hiding this comment.
Change this to be in the standard EV order for the UI input with correct mapping:
Suggested change
| for stat in ("hp", "attack", "defence", "speed", "special_attack", "special_defence"): | |
| for stat in ("hp", "attack", "defence", "special_attack", "special_defence", "speed"): |
modules/gui/ev_selection_window.py
Outdated
| window.destroy() | ||
| window = None | ||
|
|
||
| def return_selection(): |
There was a problem hiding this comment.
Change this to be in the standard EV order for the UI input with correct mapping:
Suggested change
| def return_selection(): | |
| def return_selection(): | |
| nonlocal spinboxes, selected_ev_targets | |
| selected_ev_targets = StatsValues( | |
| hp=int(spinboxes[0].get()), | |
| attack=int(spinboxes[1].get()), | |
| defence=int(spinboxes[2].get()), | |
| speed=int(spinboxes[5].get()), | |
| special_attack=int(spinboxes[3].get()), | |
| special_defence=int(spinboxes[4].get()), | |
| ) | |
| window.after(50, remove_window) |
modules/gui/ev_selection_window.py
Outdated
Comment on lines
49
to
54
| Label(window, text="HP").grid(row=0, column=1) | ||
| Label(window, text="Atk").grid(row=0, column=2) | ||
| Label(window, text="Def").grid(row=0, column=3) | ||
| Label(window, text="SpA").grid(row=0, column=4) | ||
| Label(window, text="SpD").grid(row=0, column=5) | ||
| Label(window, text="Spe").grid(row=0, column=6) |
There was a problem hiding this comment.
This works, but it is in non-standard EV ordering. If you choose to implement this solution, please do not implement any of my suggested changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
The EV target GUI window is buggy. It does not disappear after selecting the target. Closing the window before pressing the 'EV Train' button also causes the bot to freeze.
Checklist
Haven't done these
--line-length 120argument