Fix how ROMs are looked up for profiles #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading a profile, the bot has two approaches to find the correct ROM: 1. Find a ROM with the exact name stated in the profile's `metadata.yml` 2. If that fails, find a ROM that matches in game title, version number and language code. Unfortunately, there was a bug with the second approach because the bot compared a string (from `metadata.yml`) with an Enum (from `load_rom_data()`) which caused that check to always fail. So effectively, unless the ROM file name matched the bot would always complain about the ROM missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a profile, the bot has two approaches to find the correct ROM:
metadata.ymlUnfortunately, there was a bug with the second approach because the bot compared a string (from
metadata.yml) with an Enum (fromload_rom_data()) which caused that check to always fail.So effectively, unless the ROM file name matched the bot would always complain about the ROM missing.
This makes sharing profiles for debugging/testing purposes harder.