Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin/api/accounts/{id}/users done #164

Merged
merged 1 commit into from
Jan 13, 2025
Merged

admin/api/accounts/{id}/users done #164

merged 1 commit into from
Jan 13, 2025

Conversation

Gituser010
Copy link
Contributor

admin/api/accounts/{id}/users done
Get admin/api/accounts/find
Get admin/api/accounts/plan

@Gituser010 Gituser010 requested review from mkudlej and dhlavac January 9, 2025 14:36
@Gituser010 Gituser010 marked this pull request as draft January 9, 2025 14:37
@Gituser010 Gituser010 marked this pull request as ready for review January 9, 2025 14:42
mkudlej
mkudlej requested changes Jan 10, 2025
View reviewed changes
tests/integration/test_integration_account_users.py Show resolved Hide resolved
tests/integration/test_integration_account_users.py Outdated Show resolved Hide resolved
tests/integration/test_integration_accounts.py Outdated Show resolved Hide resolved
threescale_api/resources.py Outdated Show resolved Hide resolved
tests/integration/test_integration_accounts.py Outdated Show resolved Hide resolved
@Gituser010 Gituser010 force-pushed the PR branch 4 times, most recently from 11db78a to ebfade8 Compare January 13, 2025 08:16
@Gituser010
admin/api/accounts/{id}/users done
07aa09a 
Get admin/api/accounts/find
Get admin/api/accounts/plan
@Gituser010 Gituser010 requested a review from mkudlej January 13, 2025 08:31
mkudlej
mkudlej requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@mkudlej mkudlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the small fix in one test and I will approve it.

tests/integration/test_integration_account_users.py Show resolved Hide resolved
@mkudlej mkudlej self-requested a review January 13, 2025 13:55
@mkudlej mkudlej merged commit b3ab1ee into 3scale-qe:master Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkudlej mkudlej mkudlej approved these changes

@dhlavac dhlavac Awaiting requested review from dhlavac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gituser010 @mkudlej