Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for paginating thousands of results #7

Merged
merged 8 commits into from
Dec 16, 2019

Conversation

primetheus
Copy link
Collaborator

@primetheus primetheus commented Jan 8, 2019

This PR moves away from using python-ldap to python-ldap3 for better feature support. Addresses #5 and partially addresses #6

Jared Murrell added 3 commits January 8, 2019 16:13
moved from python-ldap to python-ldap3 for better feature support
@primetheus primetheus self-assigned this Jan 8, 2019
@primetheus primetheus added enhancement New feature or request bug-fix labels Jan 9, 2019
@primetheus primetheus requested review from a team January 29, 2019 18:19
@primetheus primetheus requested a review from a team September 18, 2019 16:58
Copy link
Contributor

@stoe stoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, but didn't have the chance to test,
Still want to unblock now that scheduled reminders told me to review.

@primetheus primetheus merged commit b730846 into master Dec 16, 2019
@primetheus primetheus deleted the primetheus/pagination branch January 7, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants