Making the mail attribute optional if the user attribute is there

3rd-party-integrations · Jan 5, 2022 · cd035ed · cd035ed
1 parent 380233e
commit cd035ed
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/githubapp/ldap.py b/githubapp/ldap.py
@@ -84,11 +84,16 @@ def get_group_members(self, group_name):
                                 username = str(
                                     member_dn["attributes"][self.LDAP_USER_ATTRIBUTE][0]
                                 ).casefold()
-                                email = str(
-                                    member_dn["attributes"][
-                                        self.LDAP_USER_MAIL_ATTRIBUTE
-                                    ][0]
-                                ).casefold()
+                                if member_dn["attributes"][
+                                    self.LDAP_USER_MAIL_ATTRIBUTE
+                                ]:
+                                    email = str(
+                                        member_dn["attributes"][
+                                            self.LDAP_USER_MAIL_ATTRIBUTE
+                                        ][0]
+                                    ).casefold()
+                                else:
+                                    email = None
                                 user_info = {"username": username, "email": email}
                                 member_list.append(user_info)
                         except Exception as e: