xen/arch/x86/boot/head.S: Re-enable SMI in sl_stub #8
Conversation
Signed-off-by: Kacper Stojek <[email protected]>
| /* | ||
| * Enable SMI with GETSEC[SMCTRL] which were disabled by SENTER. | ||
| */ | ||
| pushl %ebx |
There was a problem hiding this comment.
Do we have stack after GETSEC[SENTER]?
According to SDM, AC.BASE is copied from EBX to EBP, so we probably don't have to save this value.
There was a problem hiding this comment.
No we don't have a stack, but the assumption was that it will be added in other tasks, together with other code. Which is why i just stored bx like in the original source.
There was a problem hiding this comment.
But stack is already being set up later, after jumping into original entry point. Why do it twice?
There was a problem hiding this comment.
Because skipping it later was also supposed to be changed in other task. And it was done in other task, together with this change, making this PR obsolete, like it is said in a comment below.
| xorl %ebx,%ebx | ||
| movl $7,%eax |
There was a problem hiding this comment.
These probably should be #defined somewhere instead of using magic numbers.
|
THis has been already ported with full sl_stub.S file here: https://github.com/3mdeb/xen/pull/7/files#diff-1b3eb478ddc3607c91f2796e07805aa689f388f250850a2b581831c83cb7e95dR129 So I think this MR becomes obsolete now... |
Signed-off-by: Kacper Stojek [email protected]