Request GetFeatureInfo with Bootstrap5

[Gustry]

No tested, no idea.

Just to think about 3liz/lizmap-plugin#604 and 3liz/qgis-lizmap-server-plugin#87 about the migration from BootStrap 2 to BootStrap 5 in #4455

CC @mdouchin @nboisteault and @mind84

[mind84]

@Gustry,

this $projectInfos->version returns a string, something like "3.9.0-pre". I think the version could easily be extracted from this string and converted in number directly on php side. If it's reliable, form me is good then

Thanks

[Gustry]

I will first wait for @nworr and @laurentj about any slowdown if it's done at each HTTP request ?

For the string versus number, the advantage of strings is that it's more precise (beta, rc etc) if we need it later on Python side.

We can still use the string to decide between BS2 or BS5.

[Gustry]

After a discussion with @nworr :

• it's too expensive to load this XML to know this version on each HTTP requests

Either, only do this on a GetFeatureInfo request, when we need it.

Or even easier, add a BOOTSTRAP_VERSION=5 in the HTTP request. It's a hardcoded string.

[nworr]

Maybe a more generic variable name ? CSS_FRAMEWORK=BOOSTRAP5

lizmap-web-client/lizmap/modules/lizmap/lib/Request/WMSRequest.php

Line 469 in a051777

[Gustry]

PR updated and ready I guess.

It needs the branch 3liz/qgis-lizmap-server-plugin#87

[mind84]

@Gustry,

It needs the branch 3liz/qgis-lizmap-server-plugin#87

I see you updated the PR, can I do something?

Thanks

[Gustry]

No, I just pushed to your branch just now. Tests are now passing.

This PR #4769, and desktop side 3liz/lizmap-plugin#604 and server side 3liz/qgis-lizmap-server-plugin#87 are now ready ;-)

[mind84]

@Gustry,

ok! Thanks for doing all the job! ;-)