Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ranges in typing for resi AtomSelectionSpec #728

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

randyn
Copy link
Contributor

@randyn randyn commented Oct 14, 2023

  • Adds a literal type for a SelectionRange and adds it into the union type for resi
  • Adds arrays as a valid type for resi as well

There are a couple other fields on AtomSpec that are also typed as number, but I'm not sure which ones we intentionally want to allow ranges for. I'm happy to update those too, this just happened to be the only one I'm looking at right onw

@dkoes
Copy link
Contributor

dkoes commented Oct 15, 2023

Better typing is always appreciated! Although maintaining the whitespace style makes for a cleaner diff.

@dkoes dkoes merged commit 5d58638 into 3dmol:master Oct 15, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants