Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[German] Reworked Wordle sentence_translations.json #81

Merged
merged 5 commits into from
Feb 19, 2024
Merged

Conversation

wolfsgier
Copy link
Contributor

@wolfsgier wolfsgier commented Feb 4, 2024

Rework of the Wordle-video.

Copy link
Contributor

@lprecord lprecord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think many of the changes were improvements or at least didn't change things for the worse.
But there were a few fundamental questions (e.g. "du" vs "Sie") and a few recurring topics (e.g. "(Rate)versuch" instead of "Schätzung" or "Vermutung") (plus the expectable little glitches)

2022/wordle/german/sentence_translations.json Outdated Show resolved Hide resolved
2022/wordle/german/sentence_translations.json Outdated Show resolved Hide resolved
2022/wordle/german/sentence_translations.json Outdated Show resolved Hide resolved
2022/wordle/german/sentence_translations.json Show resolved Hide resolved
2022/wordle/german/sentence_translations.json Outdated Show resolved Hide resolved
2022/wordle/german/sentence_translations.json Outdated Show resolved Hide resolved
2022/wordle/german/sentence_translations.json Outdated Show resolved Hide resolved
2022/wordle/german/sentence_translations.json Outdated Show resolved Hide resolved
2022/wordle/german/sentence_translations.json Outdated Show resolved Hide resolved
2022/wordle/german/sentence_translations.json Outdated Show resolved Hide resolved
Corrected contributed errors, still needs some work
@wolfsgier wolfsgier changed the title Update sentence_translations.json reworked sentence_translations.json Feb 5, 2024
@github-actions github-actions bot added the German label Feb 5, 2024
@wolfsgier wolfsgier changed the title reworked sentence_translations.json reworked Wordle sentence_translations.json Feb 5, 2024
@wolfsgier wolfsgier changed the title reworked Wordle sentence_translations.json Reworked Wordle sentence_translations.json Feb 5, 2024
@wolfsgier wolfsgier closed this Feb 5, 2024
@wolfsgier wolfsgier reopened this Feb 5, 2024
@wolfsgier wolfsgier changed the title Reworked Wordle sentence_translations.json [German] Reworked Wordle sentence_translations.json Feb 5, 2024
@@ -1541,7 +1610,7 @@
{
"input": "By the end of the simulation, the average score works out to be about 4.124.",
"model": "nmt",
"translatedText": "Am Ende der Simulation liegt die durchschnittliche Punktzahl bei etwa 4.124.",
"translatedText": "Liegt die durchschnittliche Anzahl am Ende bei 4.124",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will we handle decimals?
"Vier-Punkt-Eins-Zwo-Vier" sounds more like some subsection of something rather than an actual decimal number like "vier-komma-eins-zwo-vier"

Copy link
Contributor

@lprecord lprecord Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will we handle decimals? "Vier-Punkt-Eins-Zwo-Vier" sounds more like some subsection of something rather than an actual decimal number like "vier-komma-eins-zwo-vier"

Very good point that slipped my attention. It's probably best to convert to ",".

@3b1b 3b1b merged commit 27c97d4 into 3b1b:main Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants