Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating zlib 1.3.1 #374

Merged
merged 1 commit into from
Jun 13, 2024
Merged

updating zlib 1.3.1 #374

merged 1 commit into from
Jun 13, 2024

Conversation

gangatp
Copy link
Collaborator

@gangatp gangatp commented Jun 13, 2024

lib3mf now uses zlib 1.3.0, which is affected by the vulnerability (BDSA-2023-2778 CVE-2023-45853). Is lib3mf affected by this? zlib(v1.3) https://autodesk.app.blackduck.com/api/components/b9185555-6e31-401e-b373-bfec7955a8ab/versions/eb888ce9-e2b6-47f7-980e-b65e7d68e92a
BDSA-2023-2778 https://autodesk.app.blackduck.com/api/vulnerabilities/BDSA-2023-2778/overview

so updating to zlib v1.3.1

Adding Mac OS target to 10.15 in cmake.

@gangatp gangatp requested a review from vijaiaeroastro June 13, 2024 10:00
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.10%. Comparing base (4889e3f) to head (9b97b0f).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #374   +/-   ##
========================================
  Coverage    71.10%   71.10%           
========================================
  Files          271      271           
  Lines        30307    30307           
========================================
  Hits         21551    21551           
  Misses        8756     8756           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@vijaiaeroastro vijaiaeroastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Pradeep.

@gangatp
Copy link
Collaborator Author

gangatp commented Jun 13, 2024

Looks good Pradeep.

Hi Vijai, I would like to merge this to develop and take this to release branch as well. Is that okay for you?

@vijaiaeroastro
Copy link
Collaborator

Sure. No issues. We have to redo all the artifacts anyway.

@gangatp gangatp merged commit e2e80ef into develop Jun 13, 2024
44 checks passed
@gangatp gangatp deleted the gangatp/update_zlib_1.3.1 branch June 13, 2024 12:03
@gangatp gangatp restored the gangatp/update_zlib_1.3.1 branch June 13, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants