Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a additional entry to build.yml to pack source code + submodules #372

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

vijaiaeroastro
Copy link
Collaborator

This artifact would be useful for people who just want to build the code with a zip file without downloading anything online. Its especially useful for VCPKG.

@vijaiaeroastro vijaiaeroastro requested a review from gangatp June 10, 2024 15:06
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.10%. Comparing base (9faac7c) to head (47f53c5).
Report is 2 commits behind head on develop.

Current head 47f53c5 differs from pull request most recent head 136761f

Please upload reports for the commit 136761f to get more accurate results.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #372   +/-   ##
========================================
  Coverage    71.10%   71.10%           
========================================
  Files          271      271           
  Lines        30307    30307           
========================================
  Hits         21551    21551           
  Misses        8756     8756           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vijaiaeroastro vijaiaeroastro force-pushed the vijai/code_with_submodules branch from 47f53c5 to 136761f Compare June 10, 2024 15:28
@vijaiaeroastro vijaiaeroastro merged commit 216be33 into develop Jun 11, 2024
84 checks passed
@vijaiaeroastro vijaiaeroastro deleted the vijai/code_with_submodules branch June 11, 2024 03:49
vijaiaeroastro added a commit that referenced this pull request Aug 3, 2024
* skipping leading whitespaces

* Update CMakeLists.txt to ignore cmake_osx_architecture in TESTS

Previously libreSSL could not be built on arm64 machines, so there was a flag to build the test only for intel x86_64 machines. 

After updating the libreSSL library, it might not be the case anymore. So removing the CMAKE_OSX_ARCHITECTURE flag.

* First batch of python examples

* Update 3mf copyright based on existing template

* Modify python imports to work with SDK package too (Even if lib3mf is not installed through PyPI, the examples would work as long as the SDK structure is maintained)

* Integration tests (#367)

* Added CMake and CPack configuration for building and packaging lib3mf across all platforms, including Debian and RPM builds + VCPKG.
* Updated and debugged workflows, .gitignore, and integration tests, ensuring smooth deployment and artifact handling.
* Fixed paths and linking issues across Windows, macOS, and Linux, including handling symlinks and double zipping problems.    
* Enhanced SDK generation and included examples for various build variants, ensuring compatibility and thorough testing.    
* Cleaned up and finalized actions, environment variables, and documentation for consistent and efficient builds and deployments.

* Integration tests (#367) + CMake Refactoring + CPack based Packaging introduction + CI / CD action improvements

* Added CMake and CPack configuration for building and packaging lib3mf across all platforms, including Debian and RPM builds + VCPKG.
* Updated and debugged workflows, .gitignore, and integration tests, ensuring smooth deployment and artifact handling.
* Fixed paths and linking issues across Windows, macOS, and Linux, including handling symlinks and double zipping problems.
* Enhanced SDK generation and included examples for various build variants, ensuring compatibility and thorough testing.
* Cleaned up and finalized actions, environment variables, and documentation for consistent and efficient builds and deployments.

* Issue-363: changing int to long long for putDoubleFactor

* fixing stringRepResenationsDiffer to use long long putFactor

* Include a additional entry to build.yml to pack source code + submodules (#372)

* Include an additional artifact that packs the code with submodules

* exclude unnecessary stuff

* avoid recursion

* avoid zip.zip

* Included a new script to automatically update lib3mf version in all the required places

* Include some rudimentary documentation in lib3mf_version_update.py

* updating zlib 1.3.1

* updating zlib 1.3.1 version file

* Update README.md

* Modify integration tests

* Fix some mistakes in integration tests

* Accidentally reverted zlib version. Switching back

* Include total must pass and must fail in all integration test outputs

* There's multiple release artifacts with .zip extension. Some adjustments are required

* Fix the issue in 2 integration test workflows. Only 1 must fail now

* Attempting to fix the last two releases action

* Cleaned a little more. All Integration tests should pass now.

* Introduce some more generics in actions (Integration test suite url is not hard coded anymore)

* Make test suite url fetching local to the test jobs

* Switch to hard coded urls for now. Can switch in the next release

* Weird osx build error fix in .yml and .sh

---------

Co-authored-by: Martin Weismann <[email protected]>
Co-authored-by: Vijai Kumar S <[email protected]>
Co-authored-by: Vijai Kumar S <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants