Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing whitespace in string to double conversion #357

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

gangatp
Copy link
Collaborator

@gangatp gangatp commented Apr 15, 2024

The current solution skips the leading whitespace and ignores it when it's at the end. if the spaces are in between then, the conversion terminates whenever a space is found.

  string        -> double

" XXXX.XX" -> xxxx.xx
" XX XX" -> xx
" XXXX.XX " -> xxxx.xx

@gangatp gangatp changed the base branch from master to develop April 15, 2024 10:45
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.22%. Comparing base (b203943) to head (f198b17).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #357      +/-   ##
===========================================
+ Coverage    69.19%   69.22%   +0.02%     
===========================================
  Files          271      271              
  Lines        28691    28692       +1     
===========================================
+ Hits         19854    19862       +8     
+ Misses        8837     8830       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinweismann
Copy link
Member

Thanks @gangatp .
Did you reformat the file?

If these files require reformatting, please do this in a separate commit , as the intended change cannot easily be recognized in the diff.

@gangatp
Copy link
Collaborator Author

gangatp commented Apr 15, 2024

Thanks @gangatp . Did you reformat the file?

If these files require reformatting, please do this in a separate commit , as the intended change cannot easily be recognized in the diff.

yes by mistake will clear it

@gangatp gangatp force-pushed the gangatp/fixing_whitespace_double_conversion branch from 0b728a0 to dd0f69c Compare April 15, 2024 15:04
@gangatp gangatp force-pushed the gangatp/fixing_whitespace_double_conversion branch from dd0f69c to f198b17 Compare April 15, 2024 17:36
Copy link
Collaborator

@vijaiaeroastro vijaiaeroastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gangatp gangatp merged commit 3a32a3e into develop Apr 30, 2024
28 checks passed
@gangatp gangatp deleted the gangatp/fixing_whitespace_double_conversion branch April 30, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants