Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending API to query required namespaces #348

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

3dJan
Copy link
Contributor

@3dJan 3dJan commented Feb 29, 2024

This PR adds a new API method to the model class that allows to query the namespaces required by extensions. This allows clients to decide weather the model can be loaded or not without any knowledge about future extensions, and without the need to parse the xml-file separately.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 64.50216% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 69.17%. Comparing base (8ceec9c) to head (0f3ab86).

Files Patch % Lines
Autogenerated/Source/lib3mf_interfacewrapper.cpp 51.36% 71 Missing ⚠️
Source/API/lib3mf_namespaceiterator.cpp 64.00% 9 Missing ⚠️
Autogenerated/Bindings/Cpp/lib3mf_implicit.hpp 93.54% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #348      +/-   ##
===========================================
- Coverage    69.20%   69.17%   -0.03%     
===========================================
  Files          271      273       +2     
  Lines        28691    28922     +231     
===========================================
+ Hits         19855    20007     +152     
- Misses        8836     8915      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3dJan 3dJan marked this pull request as draft March 4, 2024 10:04
@3dJan 3dJan marked this pull request as ready for review March 7, 2024 10:33
@3dJan 3dJan requested a review from alexanderoster May 8, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant