update googletest to v1.14.0 #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangatp
force-pushed
the
gangatp/update_googletest
branch
2 times, most recently
from
ff0fa0c to
adb26c1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #335 +/- ##
========================================
Coverage 69.74% 69.75%
========================================
Files 271 271
Lines 29758 29770 +12
========================================
+ Hits 20755 20766 +11
- Misses 9003 9004 +1 ☔ View full report in Codecov by Sentry. |
gangatp
force-pushed
the
gangatp/update_googletest
branch
2 times, most recently
from
dc3b0f1 to
9564b32
Compare
gangatp
force-pushed
the
gangatp/update_googletest
branch
from
9564b32 to
93a3098
Compare
martinweismann
requested changes
Jan 8, 2024
| @@ -1,13 +1,5 @@ | |||
| enable_testing() | |||
|
|
|||
| if (USE_INCLUDED_GTEST) | |||
There was a problem hiding this comment.
There is an opton
option(USE_INCLUDED_GTEST "Used included gtest" ON)
in the main CMakeLists.txt https://github.com/3MFConsortium/lib3mf/blob/develop/CMakeLists.txt#L27C22-L27C23 .
This shoubd be removed, too.
|
Duplicate of #336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.