update cpp-base64 #333
update cpp-base64 #333
Conversation
gangatp
force-pushed
the
gangatp/update_cpp_base64
branch
from
3c79ed4 to
daded40
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #333 +/- ##
========================================
Coverage 69.74% 69.75%
========================================
Files 271 271
Lines 29758 29770 +12
========================================
+ Hits 20755 20766 +11
- Misses 9003 9004 +1 ☔ View full report in Codecov by Sentry. |
| } | ||
| } | ||
| catch (...) { | ||
| // base64_decode throws an exception if the input is not valid base64 |
There was a problem hiding this comment.
please add specific error checking for base64_decode instead of this egeneric catch-all block.
As it is in this change, it will hide other exceptions in e.g. pXMLNode->parseXML(pXMLReader);
There was a problem hiding this comment.
okay its a runtime crash, should I introduce another Lib3mf error or use one which is already defined ?
There was a problem hiding this comment.
maybe you find a fitting one. If not, please create a new onw next to the other secure content ones.
| m_sCipherValue = std::vector<nfByte>(result.begin(), result.end()); | ||
| } | ||
| catch (...) { | ||
| // base64_decode throws an exception if the input is not valid base64 |
There was a problem hiding this comment.
same here. This exception must be handled
|
duplicate of #336 |
No description provided.