Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing code coverage #330

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Fixing code coverage #330

merged 1 commit into from
Dec 18, 2023

Conversation

gangatp
Copy link
Collaborator

@gangatp gangatp commented Dec 15, 2023

using --ignore-errors inconsistent in lcov command

https://giters.com/linux-test-project/lcov/issues/220

@gangatp gangatp changed the base branch from master to develop December 15, 2023 08:29
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 161 lines in your changes are missing coverage. Please review.

Comparison is base (791c35c) 72.80% compared to head (5cb7ce2) 69.74%.
Report is 24 commits behind head on develop.

Files Patch % Lines
Autogenerated/Bindings/Cpp/lib3mf_implicit.hpp 71.33% 86 Missing ⚠️
Autogenerated/Source/lib3mf_types.hpp 20.83% 38 Missing ⚠️
Source/API/lib3mf_model.cpp 48.48% 17 Missing ⚠️
Autogenerated/Source/lib3mf_interfaces.hpp 94.17% 6 Missing ⚠️
Source/API/lib3mf_basematerialgroupiterator.cpp 0.00% 2 Missing ⚠️
Source/API/lib3mf_colorgroupiterator.cpp 0.00% 2 Missing ⚠️
Source/API/lib3mf_compositematerialsiterator.cpp 0.00% 2 Missing ⚠️
Source/API/lib3mf_multipropertygroupiterator.cpp 0.00% 2 Missing ⚠️
Source/API/lib3mf_texture2dgroupiterator.cpp 0.00% 2 Missing ⚠️
Source/API/lib3mf_texture2diterator.cpp 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #330      +/-   ##
===========================================
- Coverage    72.80%   69.74%   -3.07%     
===========================================
  Files          418      271     -147     
  Lines        23298    29758    +6460     
===========================================
+ Hits         16963    20755    +3792     
- Misses        6335     9003    +2668     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gangatp gangatp merged commit 465c0da into develop Dec 18, 2023
22 of 24 checks passed
@gangatp gangatp deleted the gangatp/fix_code_cov branch December 18, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants