Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC-15765: update zlib to v1.3 #327

Closed
wants to merge 45 commits into from
Closed

Conversation

gangatp
Copy link
Collaborator

@gangatp gangatp commented Nov 20, 2023

The Black Duck tool detected a vulnerable outdated zlib (which is used to unzip) in lib3mf of version 1.2.11.
Update to 1.2.13 which should be the latest version in lib3mf.

See also #296 .

@gangatp gangatp marked this pull request as draft November 20, 2023 14:43
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 130 lines in your changes are missing coverage. Please review.

Comparison is base (791c35c) 72.80% compared to head (30d50c6) 69.20%.
Report is 24 commits behind head on develop.

Files Patch % Lines
Autogenerated/Bindings/Cpp/lib3mf_implicit.hpp 71.33% 86 Missing ⚠️
Autogenerated/Source/lib3mf_types.hpp 20.83% 38 Missing ⚠️
Autogenerated/Source/lib3mf_interfaces.hpp 94.17% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #327      +/-   ##
===========================================
- Coverage    72.80%   69.20%   -3.61%     
===========================================
  Files          418      271     -147     
  Lines        23298    28693    +5395     
===========================================
+ Hits         16963    19857    +2894     
- Misses        6335     8836    +2501     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gangatp
Copy link
Collaborator Author

gangatp commented Jan 8, 2024

There is another PR for updating all other libraries #336. This PR has different tries and other testing commits to check the build in all platforms, so closing this PR without merging.

@gangatp gangatp closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant